Project advertising page/form update #5777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidfischer
commented
Jun 7, 2019
davidfischer
commented
- Remove the forms to contribute to Read the Docs. We don't really get any contributions this way
- Build value for the commercial product a bit more
- More prominent get in touch for alternatives
- Remove mentions of gold. Gold doesn't remove ads from projects anymore. However, projects can get in touch.
- Remove the forms to contribute to Read the Docs We don't really get any contributions this way - Build value for the commercial product a bit more - More prominent get in touch for alternatives - Remove mentions of gold Gold doesn't remove ads from projects anymore
humitos
reviewed
Jun 10, 2019
Unfortunately our CSS doesn't support bullet lists very well. I am attempting to not write any more custom CSS until our theme work is complete. |
|
Maybe I can reuse the bullet list above in the page. It requires a special class as just using a |
|
OK, OK. It's fine as it is. I was just saying because that gray box is not used in any other place as far as I know, and I thought that a bullet list would be easy to add :) |
ericholscher
approved these changes
Jun 18, 2019
delete-merged-branch
bot
deleted the
davidfischer/project-ads-page-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.